[
https://issues.apache.org/jira/browse/CASSANDRA-16180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214031#comment-17214031
]
Caleb Rackliffe commented on CASSANDRA-16180:
---------------------------------------------
[~adelapena] [~bdeggleston] I know the main focus of this issue is testing, but
I want to propose something that bleeds into our documentation and code
organization along the way. {{StorageProxy}} is one of the most critical
classes in the entire project, but it is almost exactly 3000 lines of code and
has zero class-level JavaDoc. We should break it up into its major constituent
parts (hints, Paxos, point reads, range reads, etc.) and consider testing those
constituent parts in isolation. (There is a {{StorageProxyTest}}, but it's
really just a test for some utilities that also happen to be jammed into
{{StorageProxy}}.)
We don't have to boil the ocean either. You, [~jasonstack], and I know that SAI
is already likely going to pull the range read logic out of {{StorageProxy}},
so pulling that forward (again, assuming we have reasonable tests to avoid
risk) along w/ point reads could be a good first step. (That also corresponds
pretty closely to this Jira in particular.)
> 4.0 quality testing: Coordination
> ---------------------------------
>
> Key: CASSANDRA-16180
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16180
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 4.0
>
>
> This is a subtask of CASSANDRA-15579 focusing on coordination.
> I think that the main reference dtest for this is
> [consistency_test.py|https://github.com/apache/cassandra-dtest/blob/master/consistency_test.py].
> We should identify which other tests cover this and identify what should be
> extended, similarly to what has been done with CASSANDRA-15977.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
