[ 
https://issues.apache.org/jira/browse/CASSANDRA-16210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216764#comment-17216764
 ] 

Michael Semb Wever commented on CASSANDRA-16210:
------------------------------------------------

I think you were right originally about this patch not applying to 4.0. The 
call hierarchy to the private {{Schema.dropKeyspace(..)}}  method is only three 
only methods, all of which are {{synchronized}}.

In 3.11: at runtime it's only accessed by method in 
{{SchemaKeyspace.mergeSchema(..)}}  which is also {{synchronized}}. But the 
method itself is public and not {{synchronized}} so the tests can get into the 
race condition. Ideally i would think it's better to have synchronized at the 
test layer, but that's maybe asking a bit much for such a small fix, so I'm +1 
on the 3.11 patch. 

> Synchronize Keyspace instance store/clear
> -----------------------------------------
>
>                 Key: CASSANDRA-16210
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16210
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Cluster/Schema
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 3.11.x, 4.0-beta3
>
>
> DTest failure: 
> dtest-large.repair_tests.repair_test.TestRepairDataSystemTable.test_repair_table
>  (vnodes) - one random failure was reported which pointed to a race condition 
> to be spotted. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to