[ 
https://issues.apache.org/jira/browse/CASSANDRA-15935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217152#comment-17217152
 ] 

David Capwell commented on CASSANDRA-15935:
-------------------------------------------

Left feedback in PR; main comments were

* upgrade tests are broken
* (not a blocker) methods that use [calls|runs]OnInstance rather than their 
nodetool versions
* StorageService#waitForSchema looks to be used wrong in src/java and causes 
waits far longer than expected
* refactor joinTokenRing rather than fork (not a blocker, but makes the util 
harder to use as it behaves differently and less likely to be maintained)
* gossip helper removeFromRing assert fails with all input
* should we provide ApplicationState.NET_VERSION rather than updating messaging 
service version on all gossip mock events

> Improve machinery for testing consistency in presence of range movements
> ------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15935
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15935
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Test/dtest/java
>            Reporter: Alex Petrov
>            Assignee: Alex Petrov
>            Priority: Normal
>
> Currently, we can test range movements only by adding and bootstrapping a new 
> node. This is both inefficient and insufficient for large-scale tests. We 
> need a possibility to dynamically change ring ownership over the lifetime of 
> cluster, with a flexibility to changing gossip status of the node from 
> perspective of other participants, adding and removing nodes from other 
> nodes' views on demand.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to