[ 
https://issues.apache.org/jira/browse/CASSANDRA-16253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228808#comment-17228808
 ] 

Michael Semb Wever edited comment on CASSANDRA-16253 at 11/9/20, 8:55 PM:
--------------------------------------------------------------------------

Perfect!

Committed as 
[73a90b987dddedf6a13101c7d90114da669f52f5|https://github.com/apache/cassandra/commit/73a90b987dddedf6a13101c7d90114da669f52f5].

Thanks [~arodrime]!


was (Author: michaelsembwever):
Committed as 
[73a90b987dddedf6a13101c7d90114da669f52f5|https://github.com/apache/cassandra/commit/73a90b987dddedf6a13101c7d90114da669f52f5].

Thanks [~arodrime]!

> Fix documentation to reflect real defaults for commit logs
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-16253
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16253
>             Project: Cassandra
>          Issue Type: Task
>          Components: Documentation/Website
>            Reporter: Alain RODRIGUEZ
>            Assignee: Michael Semb Wever
>            Priority: Normal
>             Fix For: 3.11.9, 4.0-beta4
>
>
> About the documentation on commit logs:
>  * Commit logs default is every 10 sec - *periodic*, not batch 
> [https://github.com/apache/cassandra/blob/cassandra-3.11.8/conf/cassandra.yaml#L385-L386]
>  (same in 3.11.9 or trunk). It can lead to data losses but still makes sense 
> to me because fsync-ing every write is very expensive, and (even in batches) 
> should be reserved for the super paranoid where handling multiple power-out 
> (or sudden disk failures) simultaneously on multiple nodes needs to be 
> handled (as [~mck] explained to me).
>   * Nonetheless, apart from the theory behind it, in a more practical 
> perspective, *the doc is wrong* and says *Default Value: batch* which mislead 
> me and this could happen to more people: 
> [https://cassandra.apache.org/doc/latest/architecture/storage_engine.html#commit-log]
>  
> I think this is important enough for us to quickly fix the documentation in 
> trunk. As this information is fully missing in the 3.11 branch documentation, 
> I suggest we add it as well on that branch (based on information about commit 
> logs from trunk).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to