[
https://issues.apache.org/jira/browse/CASSANDRA-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045779#comment-13045779
]
Vijay commented on CASSANDRA-2733:
----------------------------------
Hi Jonathan,
1) awsApiCall in test is used by assertEquals("us-east",
snitch.getDatacenter(local)).... TestEC2Snitch hardcodes the configuration
("us-east-1d") just for this test.
2) yeah we can call the AWS API only on AWS instance hence it should timeout in
without TestEC2Snitch....
3) EC2Snitch.awsApiCall will enable us to write test case... as well as we can
reuse for the Multi-Region Snitch which i was working on.
Thanks!
> nodetool ring with EC2Snitch, NPE checking for the zone and dc
> --------------------------------------------------------------
>
> Key: CASSANDRA-2733
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2733
> Project: Cassandra
> Issue Type: New Feature
> Components: Contrib
> Affects Versions: 0.8.0
> Environment: Cassandra JVM
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 0.8.1
>
> Attachments: EC2Snitch-Patch-2733.patch, EC2Snitch-test-2733.patch
>
>
> Existing EC2Snitch... compare is done via == instead of equals() while
> comparing the IP's...
> (endpoint == FBUtilities.getLocalAddress())
> It is ok to compare the Object Address as most of the code uses
> FBU.getLocalAddress() and it returns the same object everywhere... but it
> breaks nodetool ring.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
