[
https://issues.apache.org/jira/browse/CASSANDRA-16284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242649#comment-17242649
]
Adam Holmberg commented on CASSANDRA-16284:
-------------------------------------------
Reviewed; +1 patch (non-committer). Nice test.
The one question I had was on an apparently unrelated change [removing the
sleep|https://github.com/aholmberg/cassandra/pull/19/commits/7116fdac97f61be92109269bcf48e28c82345c38#diff-d59b698a42b1c23cd68888e27f5ddcb5b112ad80a9c53a61e4561a421e55ebd2L295].
It's not totally clear why it was there in the first place. Do you know why,
or if something changed?
> Too defensive check when picking sstables for preview repair
> ------------------------------------------------------------
>
> Key: CASSANDRA-16284
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16284
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 4.0-beta4
>
>
> We fail starting any preview repair if any sstable is marked pending but the
> session not being finalized. The current check does not care if the range we
> are previewing intersects with the sstable marked pending - this means that
> we abort too many preview repairs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
