[
https://issues.apache.org/jira/browse/CASSANDRA-16200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244248#comment-17244248
]
David Capwell edited comment on CASSANDRA-16200 at 12/4/20, 7:19 PM:
---------------------------------------------------------------------
bq. Sorry not following, can you eli5 please? changes to not touch stdout? What
bug?
This is in response to the following comment {{Reviewer notes: Code is exactly
the same. The only change is that now stdout/err sometimes are captured within
the jvm dtest result sometime not. This is the change where both the captured
and jvmDtestResult stdout/err are concatenated.}}. This comment is saying that
nodetool output is making it to stdout/err and that a work around was added, if
this comment is true then it found a bug with nodetool that we should fix.
bq. I don't think that affects output as that IP is not printed,
If this is not user facing then I am fine; my only concern is if the user
facing output was changed.
Based off your replies and the code it only handles unresolved addresses, so a
resolved address would still be stored as host/address:port... curious if the
NPE you are referring to would still be impacted there.
was (Author: dcapwell):
bq. Sorry not following, can you eli5 please? changes to not touch stdout? What
bug?
This is in response to the following comment "Reviewer notes: Code is exactly
the same. The only change is that now stdout/err sometimes are captured within
the jvm dtest result sometime not. This is the change where both the captured
and jvmDtestResult stdout/err are concatenated.". This comment is saying that
nodetool output is making it to stdout/err and that a work around was added, if
this comment is true then it found a bug with nodetool that we should fix.
bq. I don't think that affects output as that IP is not printed,
If this is not user facing then I am fine; my only concern is if the user
facing output was changed.
Based off your replies and the code it only handles unresolved addresses, so a
resolved address would still be stored as host/address:port... curious if the
NPE you are referring to would still be impacted there.
> Nodetool ring unit testing
> --------------------------
>
> Key: CASSANDRA-16200
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16200
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
> Reporter: Berenguer Blasi
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 4.0-beta3
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Add nodetool ring testing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
