[
https://issues.apache.org/jira/browse/CASSANDRA-16309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246194#comment-17246194
]
Yifan Cai edited comment on CASSANDRA-16309 at 12/8/20, 11:58 PM:
------------------------------------------------------------------
The patch looks good overall. 2 nits
# Check the input value is positive in the 2 setters in {{StorageService}} for
the thresholds.
# In the test, we can set the thresholds to the current keyspace/table count
correspondingly (instead of 5 and 1), in order to test the warning is produced
at the correct threshold. It would also be nice to have test that sets the
threshold to "current count + 1"and check the warning is not produced.
was (Author: yifanc):
The patch looks good overall. 2 nits
# Check the input value is positive in the 2 setters in {{StorageService}} for
the thresholds.
# In the test, we can set the thresholds to the current keyspace/table count
correspondingly (instead of 5 and 1), in order to test the warning is produced
at the correct threshold. It would also be nice to have test that sets the
threshold to {"current count - 1"} and check the warning is not produced.
> Send back client warnings when creating a new keyspace/table and the existing
> keyspace/table count is already above a configurable threshold
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-16309
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16309
> Project: Cassandra
> Issue Type: Improvement
> Components: Cluster/Schema
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 4.0-beta4
>
>
> We should warn clients when there are dangerously many keyspaces/tables in
> the cluster
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
