[ 
https://issues.apache.org/jira/browse/CASSANDRA-16079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248455#comment-17248455
 ] 

Michael Semb Wever commented on CASSANDRA-16079:
------------------------------------------------

bq. WDYT about setting CASSANDRA_TOKEN_PREGENERATION_DISABLED on the 
constructor of TestBootstrap instead, and unset where not needed? This way new 
tests added there would use the property unless explicitly disabled.

I like the idea. But i haven't been able to implement it so far. The dtest 
classes can't have constructors, and when using @pytest.fixtures the 
{{self.cluster}} was not available yet.

bq. Also, can you maybe include this commit  (which requires this) on the ccm 
patch?

I included the latter sha 
[ab3f6c6|https://github.com/pauloricardomg/ccm/commit/ab3f6c68f01ae335ed38576fe24b48f28e9c2483],
 which seems to supersede the former 
[1b33d56|https://github.com/pauloricardomg/ccm/commit/1b33d565f2734d7b2abfe46ed3a6b1fe40780316]
 with ring_delay_ms according to the function's argument.

CI run without 13701 
[here|https://ci-cassandra.apache.org/job/Cassandra-devbranch/257/]
and without [here|https://ci-cassandra.apache.org/job/Cassandra-devbranch/258/].

> Improve dtest runtime
> ---------------------
>
>                 Key: CASSANDRA-16079
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16079
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CI
>            Reporter: Adam Holmberg
>            Assignee: Michael Semb Wever
>            Priority: Normal
>             Fix For: 4.0-beta
>
>         Attachments: Screenshot 2020-09-19 at 12.32.21.png
>
>
> A recent ticket, CASSANDRA-13701, changed the way dtests run, resulting in a 
> [30% increase in run 
> time|https://www.mail-archive.com/[email protected]/msg15606.html]. 
> While that change was accepted, we wanted to spin out a ticket to optimize 
> dtests in an attempt to gain back some of that runtime.
> At this time we don't have concrete improvements in mind, so the first order 
> of this ticket will be to analyze the state of things currently, and try to 
> ascertain some valuable optimizations. Once the problems are understood, we 
> will break down subtasks to divide the work.
> Some areas to consider:
> * cluster reuse
> * C* startup optimizations
> * Tests that should be ported to in-JVM dtest or even unit tests



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to