[
https://issues.apache.org/jira/browse/CASSANDRA-16332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17251976#comment-17251976
]
David Capwell commented on CASSANDRA-16332:
-------------------------------------------
spoke with Adam in slack; dumping context.
We talked about two options: @since(3.11) and if > 3.0 do the check. At the
end of our chat I think we settled on if > 3.0 do the check, the reasons were
the following:
* since(3.11) blocks the other asserts from happening, without an audit
(CASSANDRA-16321 still pending) we do not know if there is coverage for this
feature, so better to still keep those asserts
* if > 3.0 do check, else do old check - I don't like this as I don't think we
should be asserting the old behavior as I *feel* it was incorrect, so prefer
tests to show what we *should* do, not what we *do*
* if > 3.0 do check - this seems like the best comprise as it has the best of
both above without the two negatives listed.
> Fix upgrade python dtest test_static_columns_with_2i -
> upgrade_tests.cql_tests.TestCQLNodes
> -------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-16332
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16332
> Project: Cassandra
> Issue Type: Bug
> Components: CI, Test/dtest/python
> Reporter: David Capwell
> Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/843/workflows/9545f259-0a61-4ba8-8dea-485a33136032/jobs/4964
> {code}
> # We don't support that
> > assert_invalid(cursor, "SELECT s FROM test WHERE v = 1")
> upgrade_tests/cql_tests.py:4137:
> {code}
> {code}
> > assert False, "Expecting query to raise an exception, but nothing
> > was raised."
> E AssertionError: Expecting query to raise an exception, but
> nothing was raised.
> tools/assertions.py:63: AssertionError
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
