[
https://issues.apache.org/jira/browse/CASSANDRA-16279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Holmberg updated CASSANDRA-16279:
--------------------------------------
Test and Documentation Plan: The change is verified by uncommenting the gc
log option in the respective server.options file
([8|https://github.com/apache/cassandra/blob/ea52f1d2fa032dd28bbe69a1914497e48a6eb99a/conf/jvm8-server.options#L71],
[11|https://github.com/apache/cassandra/blob/ea52f1d2fa032dd28bbe69a1914497e48a6eb99a/conf/jvm11-server.options#L83])
and checking that the options from {{cassandra-ev.sh}} are not added if those
are already present.
Status: Patch Available (was: In Progress)
[patch|https://github.com/aholmberg/cassandra/pull/27]
[ci|https://app.circleci.com/pipelines/github/aholmberg/cassandra?branch=CASSANDRA-16279]
> Incorrect check for -Xlog in cassandra-env.sh
> ----------------------------------------------
>
> Key: CASSANDRA-16279
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16279
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
> Reporter: Yakir Gibraltar
> Assignee: Adam Holmberg
> Priority: Normal
> Fix For: 4.0-beta
>
>
> Possible small bug in {{cassandra-env.sh}} of Cassandra 4:
> [https://github.com/apache/cassandra/blob/trunk/conf/cassandra-env.sh#L98]
> The following command incorrect:
> {code}
> echo "$JVM_OPTS" | grep -q "^-[X]log:gc"
> {code}
> Should be:
> {code}
> echo "$JVM_OPTS" | grep -qe "-[X]log:gc"
> {code}
> The variable {{$JVM_OPTS}} not starting with {{-Xlog..}} , and always
> return 1, remove {{^}} and add {{-qe}} will solve the problem.
> It's causing that {{cassandra-env.sh}} ignoring variable of {{-Xlog}} in
> {{jvm11-server.options}} and {{jvm8-server.options}}
>
> Right now, jvm11-server.options with:
> {code:java}
> -Xlog:gc=info,heap*=trace,age*=debug,safepoint=info,promotion*=trace:file=/var/log/cassandra/gc.log:time,uptime,pid,tid,level:filecount=10,filesize=100M{code}
> Will generate process of:
> {code:java}
> -Xlog:gc=info,heap*=trace,age*=debug,safepoint=info,promotion*=trace:file=/var/log/cassandra/gc.log:time,uptime,pid,tid,level:filecount=10,filesize=100M
>
> -Xlog:gc=info,heap*=trace,age*=debug,safepoint=info,promotion*=trace:file=/var/log/cassandra/gc.log:time,uptime,pid,tid,level:filecount=10,filesize=10485760
> {code}
> With fix it will generate correct gc option of :
> {code}
> -Xlog:gc=info,heap*=trace,age*=debug,safepoint=info,promotion*=trace:file=/var/log/cassandra/gc.log:time,uptime,pid,tid,level:filecount=10,filesize=100M
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
