[
https://issues.apache.org/jira/browse/CASSANDRA-16374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Tunnicliffe updated CASSANDRA-16374:
----------------------------------------
Test and Documentation Plan: New unit test covering all supported protocol
versions. Protocol spec to be finalized in CASSANDRA-14688.
Status: Patch Available (was: In Progress)
Pushed a branch with the fix and new test, CI is running now.
||branch||Circle CI|Apache CI|
|[16374-trunk|https://github.com/beobal/cassandra/tree/16374-trunk]|[circle|https://circleci.com/gh/beobal/cassandra?branch=16374-trunk]|[apache|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/289]|
> Restore check for consistent native protocol versions for connection
> --------------------------------------------------------------------
>
> Key: CASSANDRA-16374
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16374
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
> Reporter: Sam Tunnicliffe
> Assignee: Sam Tunnicliffe
> Priority: Normal
> Fix For: 4.0-beta
>
>
> In protocol v4 and earlier, the frame header is checked during
> deserialization to ensure that the version matches the one negotiated for the
> connection.
> The original intention was to remove this version id from the frame (renamed
> to envelope in v5) header. However, there is value in keeping this check as
> well as the the one for the beta flag, so it remains in the frame/envelope
> format. The validation itself however, was removed by some refactoring as
> part of CASSANDRA-15299 and should be added back for all protocol versions
> before finalizing v5 and cutting a release candidate. The text detailing its
> removal also remains in the proposed spec update attached to CASSANDRA-14688,
> which also needs to be updated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
