[
https://issues.apache.org/jira/browse/CASSANDRA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272614#comment-17272614
]
Yifan Cai commented on CASSANDRA-16385:
---------------------------------------
Thanks for the patch. I left the feedback in the PR.
I think it is hard to fix the payload serializer without patching
"Message.java", since the api "Message.Serializer#serialize" serialize both
message header and payload. We could probably add a testing-only overloading
method that accepts serializer. So it can determine the serializer to use in
the in-jvm dtest framework.
+1 on "make message re-serialization itself lazy" and agree that it is separate
issue.
> Correctly serialize all request responses - CASSANDRA-15946 followup
> --------------------------------------------------------------------
>
> Key: CASSANDRA-16385
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16385
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
> Reporter: Jon Meredith
> Assignee: Jon Meredith
> Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When receiving a message, a 4.0 dtest instance reserializes messages to pass
> them through the dtest message filtering.
>
> The 4.0 internode messaging refactor does not expect to have to re-serialize
> response
> messages, so the workaround in CASSANDRA-15946 was just to register the
> ReadResponse serializer for all REQUEST_RESPONSE messages, however request
> response is used for other responses too.
> I'm attaching a patch that demonstrates the issue by adding a simple Paxos
> upgrade test to generate a PrepareResponse message that crashes the
> ReadResponse serializer, then reverts CASSANDRA-15946 and re-users the
> messaging service serialization method that checks the request callback if a
> serializer is not defined.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
