[ 
https://issues.apache.org/jira/browse/CASSANDRA-16398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276709#comment-17276709
 ] 

Yifan Cai edited comment on CASSANDRA-16398 at 2/2/21, 5:21 AM:
----------------------------------------------------------------

Starting commit

CI Results:
||Branch||Source||Circle CI||Jenkins||
|trunk|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-16398-trunk-639D5402-A26D-464E-BA14-C61A7EA11DCE]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-16398-trunk-639D5402-A26D-464E-BA14-C61A7EA11DCE]|[build|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/349/pipeline]|

The test, "mixedModeReadColumnSubsetDigestCheck - MixedModeReadTest" failed. 
Quite certain that the failure is not related with the cqlsh parser definition 
change. 

Filed the ticket for the flaky test, CASSANDRA-16415


was (Author: yifanc):
Starting commit

CI Results (pending):
|| Branch || Source || Circle CI || Jenkins ||
|trunk|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-16398-trunk-639D5402-A26D-464E-BA14-C61A7EA11DCE]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-16398-trunk-639D5402-A26D-464E-BA14-C61A7EA11DCE]|[build|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/349/pipeline]|

> Add access and datacenters to unreserved keywords
> -------------------------------------------------
>
>                 Key: CASSANDRA-16398
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16398
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CQL/Interpreter, CQL/Syntax
>            Reporter: Yifan Cai
>            Assignee: Yifan Cai
>            Priority: Normal
>             Fix For: 4.0-beta5
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> The terms, "ACCESS TO ALL DATACENTERS" (for role control,) are introduced in 
> CASSANDRA-13985. 
> They are not marked as unreserved keywords. So in the non-role related DDL 
> statements, for example, create table statement, the parser fails.
>  
> cqlsh> CREATE TABLE test.test_access ( foo text PRIMARY KEY, access text, bar 
> text);
> SyntaxException: line 1:54 mismatched input 'access' expecting ')' (... foo 
> text PRIMARY KEY, [access]...)
>  
> cqlsh> CREATE TABLE test.test_datacenters ( foo text PRIMARY KEY, datacenters 
> text, bar text);
> SyntaxException: line 1:59 mismatched input 'datacenters' expecting ')' (... 
> foo text PRIMARY KEY, [datacenters]...)
>  
> Since ACCESS and DATACENTERS are only applicable to the role defining 
> statements. We should mark them as unreserved keywords in order to allow to 
> use them in the DDL statement. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to