[
https://issues.apache.org/jira/browse/CASSANDRA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yifan Cai updated CASSANDRA-16310:
----------------------------------
Reviewers: Yifan Cai
Status: Review In Progress (was: Patch Available)
# Having setters for {{max_top_size_partition_count}} and
{{max_top_tombstone_partition_count}} suggests that we want to tweak it at
runtime. However, the property consumers, {{TopPartitionTracker}} and
{{ColumnFamilyStore}} do not update the value once initialized. So it has no
effects when operator update the values.
# {{TopPartitionsTest}} only has the test cases for full repair. Can we add
tests that run with preview repair? (I simply replaced the option in the
nodetool commands in the tests.)
## The tests cases pass with the {{--preview}} option.
## They fail with the {{--validate}} option. No sstables are selected since
the corresponding {{PreviewKind.REPAIRED}} filters out unrepaired ones.
# The todo comment at TableStatsPrinter line#131 can be removed, since it is
implemented.
# Nit: consider adding a {{isValidation()}} method to {{PreviewKind}}. So in
{{ValidationManager#doValidation}}, we can have
{{validator.getPreviewKind().isValidation()}}, instead of
{{validator.getPreviewKind() == PreviewKind.REPAIRED}}, which is less readable.
# Document the feature.
> Track top partitions (by size and tombstone count) and display in nodetool
> tablestats
> -------------------------------------------------------------------------------------
>
> Key: CASSANDRA-16310
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16310
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Other
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 4.x
>
>
> We should track the top partitions by size and tombstone count and display in
> {{nodetool tablestats}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
