[
https://issues.apache.org/jira/browse/CASSANDRA-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281938#comment-17281938
]
Andres de la Peña commented on CASSANDRA-16427:
-----------------------------------------------
The patches look good to me. Just a couple of nits:
* {{ResultSet.ResultMetadata#getPagingState}} is marked in trunk as
{{@VisibleForTesting}} in trunk but not in previous branches.
* The new {{GroupByTest}} systematically uses
{{DistributedTestBase.withKeyspace}} in some tests, and {{" + KEYSPACE + "}} in
others. Not a big deal but I think it would be nice if we did the same in all
the tests.
* Could you please run the JVM upgrade dtests too?
> In-JVM dtest paging does not handle Group By correctly
> ------------------------------------------------------
>
> Key: CASSANDRA-16427
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16427
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
> Reporter: Alex Petrov
> Assignee: Alex Petrov
> Priority: Normal
>
> In-JVM dtest paging is using a pager that disregards the type of the executed
> query, resulting into `GROUP BY` queries being executed like normal SELECT
> queries without GROUP BY clause.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
