[
https://issues.apache.org/jira/browse/CASSANDRA-15977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282684#comment-17282684
]
Andres de la Peña commented on CASSANDRA-15977:
-----------------------------------------------
[This tiny
microbenchmark|https://github.com/adelapena/cassandra/commit/9ee9119389d3b77262e10453fdca7c4db46b6f46]
seems to show that {{ColumnFilter#fetchedCellIsQueried}} is around ~2.5 times
slower with the implementation introduced by this ticket than before, and only
when the call to {{PartitionColumns#contains}} is involved:
{code}
Benchmark Mode Cnt Score Error
Units
FetchedCellIsQueriedBench.testNewImpl thrpt 5 134722.178 ± 9107.505
ops/ms
FetchedCellIsQueriedBench.testOldImpl thrpt 5 329104.675 ± 18626.088
ops/ms
{code}
That doesn't necessarily explains the reported 20-30% additional CPU load since
this is only one method of many, and it doesn't seem particularly slow in any
case. But it might make it worth trying to reduce the number of calls to
{{fetchedColumnIsQueried}} from {{fetchedCellIsQueried}}.
> 4.0 Quality: Read Repair Test Audit
> -----------------------------------
>
> Key: CASSANDRA-15977
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15977
> Project: Cassandra
> Issue Type: Task
> Components: Test/dtest/java, Test/unit
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 3.11.9, 4.0, 4.0-beta3
>
> Attachments: Screenshot 2021-02-05 at 18.01.10.png
>
> Time Spent: 13h 50m
> Remaining Estimate: 0h
>
> This is a subtask of CASSANDRA-15579 focusing on read repair.
> [This
> document|https://docs.google.com/document/d/1-gldHcdLSMRbDhhI8ahs_tPeAZsjurjXr38xABVjWHE/edit?usp=sharing]
> lists and describes the existing functional tests for read repair, so we can
> have a broad view of what is currently covered. We can comment on this
> document and add ideas for new cases/tests, so it can gradually evolve to a
> more or less detailed test plan.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
