[ 
https://issues.apache.org/jira/browse/CASSANDRA-16429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282726#comment-17282726
 ] 

Adam Holmberg edited comment on CASSANDRA-16429 at 2/10/21, 9:13 PM:
---------------------------------------------------------------------

The ResultSet Metadata encoding is failing non-ASCII characters because of an 
optimization introduced in CASSANDRA-15410, which assumes we're always encoding 
ASCII identifiers. Cassandra 
[docs|https://cassandra.apache.org/doc/latest/cql/definitions.html#identifiers] 
say identifiers are supposed to be ASCII, but that has not been enforced. So we 
will need to decide if we want to revert this optimization for compatibility, 
or if we should instead introduce unicode detection.

Paging [~yifanc] and [~aleksey] for their input. I know the microbenchmark 
showed a great improvement for this encoding in particular, but do we have some 
idea of how significantly it figures in the overall request execution?


was (Author: aholmber):
The ResultSet Metadata encoding is failing non-ASCII characters because of an 
optimization introduced in CASSANDRA-15410, which assumes we're always encoding 
ASCII identifiers. Cassandra 
[docs|https://cassandra.apache.org/doc/latest/cql/definitions.html#identifiers] 
say identifiers are supposed to be ASCII, but that has not been enforced. So we 
will need to decide if we want to revert this optimization for compatibility, 
or if we should instead introduce unicode detection.

Paging [~yifanc] and [~aleksey] for their input.

> cqlsh garbles column names with Japanese characters
> ---------------------------------------------------
>
>                 Key: CASSANDRA-16429
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16429
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CQL/Interpreter
>            Reporter: Yoshi Kimoto
>            Assignee: Adam Holmberg
>            Priority: Normal
>             Fix For: 4.0-beta
>
>         Attachments: jptest.cql
>
>
> Tables created with Japanese character name columns are working well in C* 
> 3.11.10 when doing a SELECT * in cqlsh but will show as garbled (shown as 
> "?") in 4.0-beta4. DESCRIBE shows the column names correctly in both cases.
> Run the attached jptest.cql script in both envs with cqlsh -f. They will 
> yield different results.
> My test env (MacOS 10.15.7):
> C* 3.11.10 with
>  - OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_252-b09)
>  - Python 2.7.16
> C* 4.0-beta4
>  - OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.9.1+1)
>  - Python 3.8.2



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to