[
https://issues.apache.org/jira/browse/CASSANDRA-16439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282974#comment-17282974
]
Alex Petrov commented on CASSANDRA-16439:
-----------------------------------------
Thank you for the patch!
+1. I'm not sure if we shouold keep logging statements in the test, but I don't
mind them.
> Reduce new reserved keywords introduced since 3.0
> -------------------------------------------------
>
> Key: CASSANDRA-16439
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16439
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
> Reporter: Jon Meredith
> Assignee: Jon Meredith
> Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Building on CASSANDRA-16398, for users upgrading from 3.0 to 4.0 there have
> been a few new reserved keywords added that can cause problems with schema
> changes and queries in existing applications. Reducing the number of new
> reserved words makes upgrades easier for users.
> {code:java}
> K_DEFAULT
> K_MBEAN
> K_MBEANS
> K_NEGATIVE_INFINITY
> K_NEGATIVE_NAN
> K_POSITIVE_INFINITY
> K_POSITIVE_NAN
> K_REPLACE
> K_SCHEMA
> K_UNSET
> {code}
> I think they can all be removed from the ReservedWords lists (where present)
> and added to {{basic_unreserved_keyword}} with the exception of the {\{NAN}}
> and \{{INFINITY}} as there could be ambiguity between a selected field and a
> nan/infinity literal.
> To validate I've written a test that extracts the keywords from the parser
> tokens and verifies that any non-reserved keywords can be used as table and
> column names for regular tables and materialized views. It isn't exhaustive
> but provides a good sense check.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]