[
https://issues.apache.org/jira/browse/CASSANDRA-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yifan Cai updated CASSANDRA-16415:
----------------------------------
Reviewers: Andres de la Peña, Yifan Cai, Yifan Cai (was: Andres de la Peña)
Status: Review In Progress (was: Patch Available)
Thanks you [~jlewandowski] for the patches.
The review comments were put in the corresponding PRs.
The approach/workaround sounds good. It fixes the wrong check and it can
largely _reduce_ the occurrence of digest mismatches during upgrade. The gossip
based cluster-wide version checking is still possible to produce small time
windows that nodes involved in reads hold different knowledge about the
Cassandra versions in the cluster, hence the digest mismatches. However, I
cannot think of a better way to fully eliminate, since the semantics of the
ColumnFilter has been changed multiple times without message version change and
we cannot distinguish.
We should also change the title of the ticket. It is a bug fix instead of
fixing a broken test. [~jlewandowski], please update with whatever you think is
more suitable to describe the bug.
> Broken test mixedModeReadColumnSubsetDigestCheck -
> org.apache.cassandra.distributed.upgrade.MixedModeReadTest
> -------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-16415
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16415
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Coordination, Test/dtest/java
> Reporter: Yifan Cai
> Assignee: Jacek Lewandowski
> Priority: Normal
> Fix For: 3.11.x, 4.0-beta
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The test has been failing and can always be reproduced in the recent CI.
> Stack trace:
> {code:java}
> junit.framework.AssertionFailedError: Found Digest Mismatch
> at
> org.apache.cassandra.distributed.upgrade.MixedModeReadTest.checkTraceForDigestMismatch(MixedModeReadTest.java:89)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeReadTest.lambda$mixedModeReadColumnSubsetDigestCheck$0(MixedModeReadTest.java:63)
> at
> org.apache.cassandra.distributed.upgrade.UpgradeTestBase$TestCase.run(UpgradeTestBase.java:171)
> at
> org.apache.cassandra.distributed.upgrade.MixedModeReadTest.mixedModeReadColumnSubsetDigestCheck(MixedModeReadTest.java:76)
> {code}
> The initial investigation shows that
> * The test only fails in the setup phase of
> mixedModeReadColumnSubsetDigestCheck. The cluster version is
> *Versions.Major.v3X*
> * The test failure is likely a consequence of CASSANDRA-15962. After
> dropping the commit in branch cassandra-3.11 and rebuild the dtest jar, the
> upgrade test can pass. Meanwhile, dropping the other commits does not help.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
