[
https://issues.apache.org/jira/browse/CASSANDRA-16216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295142#comment-17295142
]
Benjamin Lerer commented on CASSANDRA-16216:
--------------------------------------------
Sorry for the long delay [~sumanth.pasupuleti].
I have some minor comments:
* Rather than using {{CQLTester.prepareServer();}} I would use
{code}
ServerTestUtils.daemonInitialization();
ServerTestUtils.prepareServer();
{code}
to avoid some of the useless static initialization of {{CQLTester}}
* I would add a small comment to explain that the java driver use a control
connection to get the token map, node list and schema and the connections from
the pool (in our case 1 for V3+ protocol). To avoid people of being surprise by
seing 2 connections.
* It would be nice to add a test to check
{{org.apache.cassandra.metrics.Client.AuthFailure}}
> Add tests to cover ClientMetrics metrics
> ----------------------------------------
>
> Key: CASSANDRA-16216
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16216
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java, Test/unit
> Reporter: Sumanth Pasupuleti
> Assignee: Sumanth Pasupuleti
> Priority: Normal
> Fix For: 4.0-rc
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
