[ 
https://issues.apache.org/jira/browse/CASSANDRA-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296415#comment-17296415
 ] 

Ekaterina Dimitrova edited comment on CASSANDRA-16489 at 3/8/21, 2:10 PM:
--------------------------------------------------------------------------

I was thinking to commit the patch tonight but there is one thing I just saw.

_utest_system_keyspace_directory_ turns out to need approval to be started not 
only by _utest_system_keyspace_directory_ but also by _utests_fqltool_

For reference, please, check the line connections in the diagram from the  
[JAVA8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/668/workflows/fdc790c1-86ed-4132-9bd7-8f514e7d957]
 CI run

I know this was set during the initial addition of the tests but I think it is 
wrong, we should be able to start them as unit tests in their own group. I 
don't think those have anything in common with the FQLtool. (CC [~blerer] as an 
author to correct me in case I am wrong :))


was (Author: e.dimitrova):
I was thinking to commit the patch tonight but there is one thing I just saw.

_utest_system_keyspace_directory_ turns out to need approval to be started not 
only by _utest_system_keyspace_directory_ but also by _utests_fqltool_

For reference, please, check the line connections in the diagram from the  
[JAVA8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/668/workflows/fdc790c1-86ed-4132-9bd7-8f514e7d957]
 CI run

I know this was set during the initial addition of the tests but I think it is 
wrong, we should be able to start them as unit tests in their own group. I 
don't think those have anything in common with the FQLtool. (CC [~blerer] as an 
author to. corrected me in case I am wrong :))

> Add utest_system_keyspace_directory to CircleCI config template
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-16489
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16489
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CI
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>            Priority: Normal
>             Fix For: 4.0, 4.0-beta
>
>
> In CASSANDRA-14793 a new circle job config was added directly to the CircleCI 
> base, LOWRES, MIDRES and HIGHRES config files, but not to the template file. 
> When the config was regenerated for CASSANDRA-16474, the new job was lost. We 
> should restore it and add it to the config template to avoid any reoccurrence.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to