[
https://issues.apache.org/jira/browse/CASSANDRA-16216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300259#comment-17300259
]
Andres de la Peña edited comment on CASSANDRA-16216 at 3/12/21, 12:06 PM:
--------------------------------------------------------------------------
I have a few more minor comments:
* It seems that additionally to {{AuthFailure}} we are also missing
{{ConnectedNativeClientsByUser}}, {{RequestsSize}} and
{{RequestsSizeByIpDistribution}} metrics.
* I think that {{EmbeddedCassandraService}} in the new {{ClientMetricsTest}}
doesn't need to be a static field, it can be a local variable in
{{ClientMetricsTest.setUp}}.
* The methods {{ClientMetricsTest::getMeter}}, {{ClientMetricsTest::getGauge}}
and {{ClientResourceLimitsTest::getRequestDiscardedMeter}} could be static.
* The method {{ClientMetricsTest::getGauge}} could be marked with
{{@SuppressWarnings("rawtypes")}}.
was (Author: adelapena):
I have a few more minor comments:
* It seems that additionally to {{AuthFailure}} we are also missing
{{ConnectedNativeClientsByUser}}, {{RequestsSize}} and
{{RequestsSizeByIpDistribution}} metrics.
* I think that {{EmbeddedCassandraService}} in the new {{ClientMetricsTest}}
doesn't need to be a static field, it can be a local variable in
{{ClientMetricsTest.setUp}}.
* The methods {{ClientMetricsTest::getMeter}, {{ClientMetricsTest::getGauge}}
and {{ClientResourceLimitsTest::getRequestDiscardedMeter}} could be static.
* The method {{ClientMetricsTest::getGauge}} could be marked with
{{@SuppressWarnings("rawtypes")}}.
> Add tests to cover ClientMetrics metrics
> ----------------------------------------
>
> Key: CASSANDRA-16216
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16216
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java, Test/unit
> Reporter: Sumanth Pasupuleti
> Assignee: Sumanth Pasupuleti
> Priority: Normal
> Fix For: 4.0-rc
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
