[ 
https://issues.apache.org/jira/browse/CASSANDRA-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049493#comment-13049493
 ] 

Brandon Williams commented on CASSANDRA-2491:
---------------------------------------------

Mostly looks good.  A few things I noticed:

* If so, there's a typo in "receiveMessage"
* SimpleSnitch and AbstractNetworkTopologySnitch are importing DD but not using 
it
* the VersionedValue addition probably doesn't belong here

bq. Allow brodcastAddress to be set by snitch so we can automate via snitch 
(property or EC2MultiregionSnitch).

Can you explain why that's necessary?  It seems to me if the node doesn't know 
it's own BA when it starts up, it's already going to get into trouble.


> A new config parameter, broadcast_address
> -----------------------------------------
>
>                 Key: CASSANDRA-2491
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2491
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>         Environment: x86_64 GNU/Linux
>            Reporter: Khee Chin
>            Assignee: Khee Chin
>            Priority: Trivial
>              Labels: patch
>             Fix For: 1.0
>
>         Attachments: 2491_broadcast_address.patch, 
> 2491_broadcast_address_v2.patch, 2491_broadcast_address_v3.patch
>
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> A new config parameter, broadcast_address
> In a cluster setup where one or more nodes is behind a firewall and has a 
> private ip address, listen_address does not allow the hosts behind the 
> firewalls to be discovered by other nodes.
> Attached is a patch that introduces a new config parameter broadcast_address 
> which allows Cassandra nodes to explicitly specify their external ip address. 
> In addition, this allows listen_address to be set to 0.0.0.0 on the already 
> firewalled node.
> broadcast_address fallsback to listen_address when it is not stated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to