[ 
https://issues.apache.org/jira/browse/CASSANDRA-16236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309572#comment-17309572
 ] 

Andres de la Peña commented on CASSANDRA-16236:
-----------------------------------------------

I'm glad you like it :) 

Looking for other similar calls to {{Assert.assertEquals(float, float, float)}} 
across the codebase, I have found that {{SSTableMetadataTrackingTest}}, which 
is quite similar to {{SSTableMetadataTest}}, might have the same problem. I 
have added a similar fix for it in the PR.

I can't find other similar cases, which would be anything calling 
{{Assert.assertEquals(float, float, float)}} with big integers, greater than 
2^24 (16777216) if I'm right.

New CI runs:
 * [CircleCI 
j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/242/workflows/ff53bab0-0840-4df7-98de-70b98611f0af]
 * [CircleCI 
j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/242/workflows/ca7e2484-f94c-4c03-b62a-c4fb445405b3]
 * [ci-cassandra 
utest|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-test/337/]
 * [Internal 
multiplexer|https://jenkins-dse.build.dsinternal.org/view/Parameterized/job/parameterized-testall/745/]

> Fix flaky testTrackMaxDeletionTime
> ----------------------------------
>
>                 Key: CASSANDRA-16236
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16236
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: Brandon Williams
>            Assignee: Andres de la Peña
>            Priority: Normal
>             Fix For: 4.0-rc
>
>         Attachments: Screenshot 2021-03-23 at 20.12.18.png
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> * 
> testTrackMaxDeletionTime - org.apache.cassandra.io.sstable.SSTableMetadataTest
>  
> junit.framework.AssertionFailedError: expected:<1.6038784E9> but 
> was:<1.60387827E9>
>       at 
> org.apache.cassandra.io.sstable.SSTableMetadataTest.testTrackMaxDeletionTime(SSTableMetadataTest.java:102)
> https://app.circleci.com/pipelines/github/bereng/cassandra/160/workflows/6cb80410-b398-477c-b4c9-cc7369785869/jobs/1317



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to