[
https://issues.apache.org/jira/browse/CASSANDRA-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stu Hood updated CASSANDRA-2629:
--------------------------------
Attachment: 0002-CASSANDRA-2629-Remove-the-retry-with-key-from-index-st.txt
0001-CASSANDRA-2629-Move-key-and-row-size-reading-into-the-.txt
bq. move "long rowSizeFromIndex = nextRowPositionFromIndex -
currentRowPositionFromIndex;" into the IF statement where it is needed
Done.
bq. in your log warnings, specifying the actual sstable will help with debugging
Scrub starts with a log entry to indicate which file is being scrubbed... this
should be sufficient unless someone is running without INFO.
bq. remove "this.key = key;" for both constructors
Good catch... that line was a noop in the second constructor: we don't know the
key until init() is called, so we can't make it final.
bq. *init() method should be more descriptive
Was supposed to say "Reads the key and row length from the head of the row.":
fixed.
bq. remove @param key comment from IFilter.java and SSTableSliceIterator.java
Fixed.
bq. safer to updateCache(iter) AFTER appending to writer
I think the whole thing is racey, because the entire rebuilding process can
fail, which might mean that the cache was updated when it shouldn't have been.
----
I didn't make the close() change: we talked about close a little bit offline, I
think we reached the consensus that having two methods that you must always
call won't be an improvement over close. I also didn't add back the scrub
retry: I agree that we can do better there, but I think it will be easier to
improve once we have the checksumming from 674: at the moment the reasons for
doing certain things with the API would not be clear at all.
Thanks for the review!
> Move key reads into SSTableIterators
> ------------------------------------
>
> Key: CASSANDRA-2629
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2629
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Stu Hood
> Fix For: 1.0
>
> Attachments:
> 0001-CASSANDRA-2629-Move-key-and-row-size-reading-into-the-.txt,
> 0002-CASSANDRA-2629-Remove-the-retry-with-key-from-index-st.txt
>
>
> All SSTableIterators have a constructor that assumes the key and length has
> already been parsed. Moving this logic inside the iterator will improve
> symmetry and allow the file format to change without iterator consumers
> knowing it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
