[
https://issues.apache.org/jira/browse/CASSANDRA-16558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315199#comment-17315199
]
Ekaterina Dimitrova commented on CASSANDRA-16558:
-------------------------------------------------
+1 from me too.
Only
[this|https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16558/trunk#diff-d274784b2fecdbee879b6175c05a9860374c65c0c0b7e87efe8ec66c0fc3d838R41]
needs to be rat.txt, same as in the other branches, also this is really the
name of the file created. (git doesn't allow me to leave comments on the
commits :( )
_Suggestion for additions I can support as part of this ticket:_
I think we might also want to check for license header for files with the
following extensions - .spec, .md, .iml, .bat, .btm (maybe?), .cql, css, csv,
.g, .hmtl, jflex, jks, .mod, .name, .pom, .textile, .yml (circle ci config,
maybe?), .yaml.
As talked in Slack with Mick, I suggested to add a License Compliance file (my
initial suggestion can be found [here
|https://github.com/ekaterinadimitrova2/cassandra/blob/b43085aed7e77715a313a2885e8f94037e7cbecd/src/java/org/apache/cassandra/concurrent/LICENSE_COMPLIANCE.md])
which could be of benefit to provide overview and maybe guidance for people
when in doubt. The idea came after seeing similar files added to other Apache
projects and seems it might be helpful?
I was also thinking whether to add a listing of all the file extensions we
currently have with comment which of those currently require a header and which
were revised and do not contain a "creativity" part (respectively the license
header is not expected). WDYT?
DISCLAIMER: as a non-native speaker I might have not said everything in the
best possible way in the document so feel free to chime in with suggestions for
improvement. :)
> Fix rat check (April 2021)
> --------------------------
>
> Key: CASSANDRA-16558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16558
> Project: Cassandra
> Issue Type: Task
> Components: Build, Packaging
> Reporter: Michael Semb Wever
> Assignee: Michael Semb Wever
> Priority: High
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x
>
>
> The rat plugin in build.xml is a mess and not properly catching missing
> license headers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
