[
https://issues.apache.org/jira/browse/CASSANDRA-16561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315490#comment-17315490
]
Brandon Williams commented on CASSANDRA-16561:
----------------------------------------------
Well, I thought you were wrong and so I went all the way back to CASSANDRA-1518
when we began persisting them...and indeed, younger me only populated TMD and
not gossip. I feel like this must have been oversight on my part though, since
having the empty state in gossip doesn't really make any sense without any kind
of information attached to it. Or at least, I can't see how it's useful.
So it seems like either we a) shouldn't bother populating an empty state at all
or b) we should populate it with the tokens/host_id like present me _thought_
it worked. To option b) I still believe, however rare, the "bootstrap after
full cluster restart with some nodes kept down" scenario will still be
problematic, as will any others where a node thinks it can get an accurate ring
view from shadow gossip in that situation.
> Gossip is not populated with tokens/host_ids
> --------------------------------------------
>
> Key: CASSANDRA-16561
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16561
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Gossip
> Reporter: Brandon Williams
> Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x
>
>
> Originally when we began persisting host information such a tokens/host_id,
> we would populate gossip with this information. At some point we began only
> populating TokenMetadata, which gives us most of the same benefit, but in a
> full ring restart where the gossip ether is empty, it populates useless info
> such as :
> {quote}
> /10.101.32.212
> generation:0
> heartbeat:0
> TOKENS: not present
> {quote}
> which is the minimum required for a state to exist. Instead we should keep
> gossip in sync with TMD when populating this information like we used to do.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
