[
https://issues.apache.org/jira/browse/CASSANDRA-16575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316992#comment-17316992
]
Michael Semb Wever edited comment on CASSANDRA-16575 at 4/8/21, 9:14 AM:
-------------------------------------------------------------------------
{quote}
I vote for removing compression configuration and actually allow to manually
specify yaml file to be used for testing as a test property, as well as allow
to manually specify extra system properties to be passed to the test. That
would make the build more flexible and remove a bit of redundant code.
{quote}
+1
I think we should (at least try to) track down the devs who added the
{{test-compression}} variant to CI to find out why it was important at the time.
was (Author: michaelsembwever):
{quote}
I vote for removing compression configuration and actually allow to manually
specify yaml file to be used for testing as a test property, as well as allow
to manually specify extra system properties to be passed to the test. That
would make the build more flexible and remove a bit of redundant code.
{quote}
+1
I think we should track down the devs who added the {{test-compression}}
variant to CI to find out why it was important at the time.
> "compression" configuration in unit tests is incorrect and actually redundant
> -----------------------------------------------------------------------------
>
> Key: CASSANDRA-16575
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16575
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Jacek Lewandowski
> Priority: Normal
>
> When running unit tests with "compression" configuration, we actually not use
> compression at all we run just unit tests without compression (which is
> redundant when running on CI).
> The reason is that for the compression configuration we (try to) do the
> following:
> {code}
> <property name="compressed_yaml"
> value="${build.test.dir}/cassandra.compressed.yaml"/>
> <concat destfile="${compressed_yaml}">
> <fileset file="${test.conf}/cassandra.yaml"/>
> <fileset file="${test.conf}/commitlog_compression.yaml"/>
> </concat>
> {code}
> however, {{cassandra.compressed.yaml}} has been replaced in CASSANDRA-14482
> by two files {{commitlog_compression_LZ4.yaml}} and
> {{commitlog_compression_Zstd.yaml}} without changing build configuration.
> All in all we could fix that but I doubt it makes any sense since {{cdc}}
> configuration already uses compressed commit log anyway so it feels redundant
> to test compression alone for each CI run.
> I vote for removing compression configuration and actually allow to manually
> specify yaml file to be used for testing as a test property, as well as allow
> to manually specify extra system properties to be passed to the test. That
> would make the build more flexible and remove a bit of redundant code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
