[
https://issues.apache.org/jira/browse/CASSANDRA-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326916#comment-17326916
]
Jeremiah Jordan edited comment on CASSANDRA-16619 at 4/21/21, 9:10 PM:
-----------------------------------------------------------------------
[~dcapwell] this isn't just about ZCS. Any backup/restore process that copied
an SSTable around is also affected. If a given node did not create the
CommitLogPosition information then it needs to be ignored when loading the
sstable. Hence the proposal to store the hostid in the metadata. If the
hostid in the sstable doesn't match the hostid of the current node, then you
can just ignore that erroneous information. This affects 3.x clusters as well,
not just 4.x with ZCS.
was (Author: jjordan):
[~dcapwell] this isn't just about ZCS. Any backup/restore process that copied
an SSTable around is also affected. If a given node did not create the
CommitLogPosition information then it needs to be ignored when loading the
sstable.
> Loss of commit log data possible after sstable ingest
> -----------------------------------------------------
>
> Key: CASSANDRA-16619
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16619
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Commit Log
> Reporter: Jacek Lewandowski
> Assignee: Jacek Lewandowski
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> SSTable metadata contains commit log positions of the sstable. These
> positions are used to filter out mutations from the commit log on restart and
> only make sense for the node on which the data was flushed.
> If an SSTable is moved between nodes they may cover regions that the
> receiving node has not yet flushed, and result in valid data being lost
> should these sections of the commit log need to be replayed.
> Solution:
> The chosen solution introduces a new sstable metadata (StatsMetadata) -
> originatingHostId (UUID), which is the local host id of the node on which the
> sstable was created, or null if not known. Commit log intervals from an
> sstable are taken into account during Commit Log replay only when the
> originatingHostId of the sstable matches the local node's hostId.
> For new sstables the originatingHostId is set according to StorageService's
> local hostId.
> For compacted sstables the originatingHostId set according to
> StorageService's local hostId, and only commit log intervals from local
> sstables is preserved in the resulting sstable.
> discovered by [~jakubzytka]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
