[
https://issues.apache.org/jira/browse/CASSANDRA-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329206#comment-17329206
]
Ekaterina Dimitrova edited comment on CASSANDRA-16623 at 4/22/21, 3:37 PM:
---------------------------------------------------------------------------
Seeing your comment I tested with single test and that definitely returns
nothing. I was testing other options before where it was giving info for runs.
But it seems it is really not OK for all use cases and doesn't serve its goal.
Thanks for raising it.
[~mck] confirmed the script is still used at places like
[here|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-dtest-pytest.sh#L89].
So we are not removing it but it seems we are all on the same page, agreeing
with the readme change.
+1 I will commit it soon, thanks [~mfleming]
was (Author: e.dimitrova):
Seeing your comment I tested with single test and that definitely returns
nothing. I was testing other options where it was giving info for runs so it
seems it is really not OK. Thanks for raising it.
[~mck] confirmed the script is still used at places like
[here|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-dtest-pytest.sh#L89].
So we are not removing it but it seems we are all on the same page, agreeing
with the readme change.
+1 I will commit it soon, thanks [~mfleming]
> Remove references to run_dtests from README
> -------------------------------------------
>
> Key: CASSANDRA-16623
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16623
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/python
> Reporter: Matt Fleming
> Assignee: Matt Fleming
> Priority: Low
> Fix For: 4.0.x
>
>
> Newcomers to cassandra-dtest that look through README.md will see that the
> run_dtests.py script is the quickest way to get started running tests.
> Unfortunately, the script has a number of problems and I'm not sure it ever
> work properly after the move to the pytest framework.
> h2. Process stdout/stderr buffering
> Firstly, when I execute run_dtests.py I don't see any output after
> {{$ ./run_dtests.py --dtest-tests paging_test.py }}
> {{============================= test session starts
> ==============================}}
> This looks likely to be because of the buffering that pytest does internally
> for stdout and stderr and because of the way that it's executed by
> run_dtests.py, i.e. I suspect that run_dtests.py is blocked on the following
> line for most of the execution because there's no data available in the pipe
> for stderr:
> {{stderr_output = sp.stderr.readline()}}
> See also [https://github.com/pytest-dev/pytest/issues/1886]
> h2. --pytest-options doesn't work
> Secondly, the options specified in --pytest-options aren't actually passed
> through to pytest.
> h2. Most devs run pytest directly
> When I spoke to [~edimitrova] it seemed like most developers just run the
> tests directly with pytest which would explain why run_dtests.py has
> bitrotted.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
