[
https://issues.apache.org/jira/browse/CASSANDRA-16614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17330019#comment-17330019
]
Berenguer Blasi commented on CASSANDRA-16614:
---------------------------------------------
[~adelapena] excellent analysis. My patch would be testing sometimes while in
MOVING state and sometimes when the node had already moved back to NORMAL,
which is what I had seen perusing the logs. That is not correct and your patch
is the right choice. I think you should take this ticket as you pinned it down.
I multiplexed it locally a bit to make sure and LGTM so I am +1 on your patch
{noformat}
pytest --count 30 -rP --cassandra-dir=~/work/repos/bdpWS/16614
pending_range_test.py::TestPendingRangeMovements::test_pending_range
30 passed in 1558.32 seconds
{noformat}
Also ins the spirit of CASSANDRA-16625 and just bc it is super useful would you
be ok we add dtest-repeat to requirements.txt? It is what I used to multiplex
locally your dtest commit. Feel free to decline ofc
{noformat}
diff --git a/requirements.txt b/requirements.txt
index 8e7ac0a9..cf618d50 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -14,6 +14,7 @@ flaky
mock
pytest==3.6.4
pytest-timeout
+pytest-repeat
parse
pycodestyle
psutil
{noformat}
> Flaky test_pending_range
> ------------------------
>
> Key: CASSANDRA-16614
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16614
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
> Reporter: Berenguer Blasi
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 4.0-rc
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Flaky
> [test_pending_range|https://ci-cassandra.apache.org/job/Cassandra-trunk/445/testReport/junit/dtest-large-novnode.pending_range_test/TestPendingRangeMovements/test_pending_range/]
> {noformat}
> Error Message
> AssertionError: assert None is not None + where None = <function search at
> 0x7f29dfa83b80>('127\\.0\\.0\\.1.*?Down.*?Moving', '\nDatacenter:
> datacenter1\n==========\nAddress Rack Status State Load
> Owns ... rack1 Up Normal 90.86 KiB
> 40.00% 5534023222112865484 \n\n\n ') +
> where <function search at 0x7f29dfa83b80> = re.search
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
