[
https://issues.apache.org/jira/browse/CASSANDRA-16654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344515#comment-17344515
]
Andres de la Peña commented on CASSANDRA-16654:
-----------------------------------------------
{quote}There's no easy way to make ant take a runner as a parameter. You have
to create a plugin etc etc. Alternatives are also quite involved. If I have not
lost track of the things I think what we have is the most reasonable option.
{quote}
Agree, I played a bit with {{JUnitTask}}/{{JStackJUnitTask}} while working on
the CircleCI multiplexer and it seems probably more involved than we need right
now. I think it's better if we commit this as it is, so it starts to help us
with 4.0 immediately. We can always come back later to add the repetitions as
an Ant parameter.
{quote}Edit: Added doc notes.
{quote}
The new section about flaky tests is nice, thanks. I've left a couple of very
minor suggestions in the PR that can be addressed during commit.
I think we are ready to commit. IMO it would be nice if we added the runner
also to 3.0 and 3.11, it should be a straightforward merge.
Also, just a reminder to remove the usages of {{RepeatableRunner}} that we have
added as examples ({{DirectoriesTest}}, {{ColumnFilterTest}},
{{AssureSufficientLiveNodesTest}} and {{SpeculativeRetryParseTest}})
> Junit RepeatableRunner flaky tests helper
> -----------------------------------------
>
> Key: CASSANDRA-16654
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16654
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Berenguer Blasi
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.1
>
>
> Some flakies only fail when the full suite is ran. If it's a quick test you
> can do thousands of runs if a few seconds. Looping at the sh level is not an
> option as every loop takes a few seconds.
> As I have found this very useful I am proposing committing it
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
