[
https://issues.apache.org/jira/browse/CASSANDRA-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351096#comment-17351096
]
Andres de la Peña commented on CASSANDRA-16687:
-----------------------------------------------
[~e.dimitrova] thanks for the review.
{quote}The only thing that I am not sure about is why the python dtest upgrade
tests' artifacts are not enumerated similar to the regular python dtests. I see
you still use the pytest count argument. Any ideas?
{quote}
I think both dtests and upgrade dtests produce the same naming of artifacts.
Both use {{pytest-repeat}}, and they invoke the same CircleCI command. The only
difference is the addition of the {{--execute-upgrade-tests-}} flag. Maybe what
is confusing about the examples in my previous comment is that, in an attempt
to save resources, the number of repetitions is lower than the number of
runners. Because of this low count the per-runner iteration count is either
zero or one. In case of using {{-count=1}} pytest just doesn't add an iteration
number to the artifacts. In [this other
run|https://app.circleci.com/pipelines/github/adelapena/cassandra/499/workflows/6083ebba-cf7c-49cb-9ce0-1bdd446ff7cf]
with an iteration count greater than the number of runners we will hopefully
see the iteration numbers for both
[dtests|https://app.circleci.com/pipelines/github/adelapena/cassandra/499/workflows/6083ebba-cf7c-49cb-9ce0-1bdd446ff7cf/jobs/4533/artifacts]
and [upgrade
dtests|https://app.circleci.com/pipelines/github/adelapena/cassandra/499/workflows/6083ebba-cf7c-49cb-9ce0-1bdd446ff7cf/jobs/4537].
It's still running.
{quote}I left just a few small comments/questions.
{quote}
I can't answer some of the comments on the PR conversation, and the related
commits are gone after rebasing, so I'll try to answer them here:
{quote}This is probably copy-paste and it should be actually name: {{Run
repeated jvm upgrade dtest}} ?
{quote}
{quote}same here
{quote}
{quote}and here :)
{quote}
{quote}just pointing the occurrences for reference
{quote}
Those changes are in the {{config.yml}}, {{config.yml.LOWRES}},
{{config.yml.MIDRES}} and {{config.yml.HIGHRES}}. These files are generated
automatically from {{config-2_1.yml}} by CircleCI CLI. The tool just replaces
all calls to the command/script that we use by the script itself, so we end up
with multiple copies of the script spread across the file. The name of the
reused script has to be the same for {{j8_repeated_utest}},
{{j11_repeated_utest}} and {{repeated_jvm_upgrade_dtest}}, so I think we can't
use {{Run repeated jvm upgrade dtest}} either because it will end up in the
non-upgrade tests too. I have changed it to the more generic {{Run repeated
JUnit test}}.
{quote}I realized we miss long-testsome
{quote}
{quote}also probably burn-testome?
{quote}
That wasn't intended to be an exhaustive list of all the possible Ant targets
but just a bunch examples. I can change that to enumerate all the available Ant
test targets, wdyt?
{quote}I am not sure whether someone new won't really write o.a.c.d.u.?
{quote}
I understand you abbreviated it probably because it doesn't fit in the doc
table, but someone brand new might copy -paste it directly. Is there a shorter
name jvm upgrade test we can pick? :D
{quote}Actually, I see you have the full name as a comment in the config file
so I hope people will see that one
{quote}
Right, I abbreviated that trying to make it fit in the claustrophobic space of
the table. Indeed abbreviating the name can be confusing for users, and
unfortunately all the JVM upgrade tests are in that package. I have expanded
the package name and used a multi-line bullet point with two separate verbatim
parts. It's not a super nice formatting when converted into html, but I think
it does the trick.
> Support upgrade tests in CircleCI multiplexer
> ---------------------------------------------
>
> Key: CASSANDRA-16687
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16687
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The CircleCI jobs for running a test repeatedly added by CASSANDRA-16625
> don't support upgrade tests. In the case of Python upgrade dtests we only
> need the {{--execute-upgrade-tests}} when calling {{pytest}}. For Java
> upgrade tests we need to build the dtest jars before running the repeated
> tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
