[
https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365293#comment-17365293
]
Alex Petrov commented on CASSANDRA-16649:
-----------------------------------------
Left a small comment (create files during tests vs storing them in repository)
in dtest. Since most of version and comparing was already implemented, I
personally would have just added support for 4.x and rc/beta/alpha. However, I
do not have a strong opinion in this specific case, since it's used in tests.
If we do run into dependency conflict and one of our dependencies has semver4j
as a transitive dependency, we can just revert and implement it "natively".
Just to make sure this is mentioned: changes made to dtests have to be applied
to all branches that have dtest api referenced.
+1
> Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
> ------------------------------------------------------------------------------
>
> Key: CASSANDRA-16649
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16649
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/dtest/java
> Reporter: Michael Semb Wever
> Assignee: Michael Semb Wever
> Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> -
> https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649
> -
> https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
