[ 
https://issues.apache.org/jira/browse/CASSANDRA-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365083#comment-17365083
 ] 

Laurenceau Julien edited comment on CASSANDRA-7450 at 6/18/21, 2:44 PM:
------------------------------------------------------------------------

Datastax documentation may need an update because it still states:

> {color:#1d1c1d}Additional guidance for {color}{{nodetool 
> repair}}{color:#1d1c1d} options: Does not support the use of 
> {color}{{-local}}{color:#1d1c1d} with the {color}{{-pr}}{color:#1d1c1d} 
> option unless the datacenter nodes have all the data for all ranges{color}

 


was (Author: julienlau):
It may be necessary to update the documentation which still states:

> {color:#1d1c1d}Additional guidance for {color}{{nodetool 
> repair}}{color:#1d1c1d} options: Does not support the use of 
> {color}{{-local}}{color:#1d1c1d} with the {color}{{-pr}}{color:#1d1c1d} 
> option unless the datacenter nodes have all the data for all ranges{color}

 

> Make repair -pr work within a datacenter
> ----------------------------------------
>
>                 Key: CASSANDRA-7450
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7450
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Legacy/Streaming and Messaging
>            Reporter: Sylvain Lebresne
>            Assignee: Paulo Motta (Deprecated)
>            Priority: Normal
>              Labels: bootcamp, repair
>             Fix For: 2.1.1
>
>         Attachments: 2.1-CASSANDRA-7450-v1.txt, 2.1-CASSANDRA-7450-v2.txt, 
> 7450-2.1-v3.txt
>
>
> As was noticed in CASSANDRA-7317, using '-pr' alongside '-local' for repair 
> doesn't really work properly, and disabling the combination was definitively 
> the right short time fix. However, the main goal of '-pr' is to make it easy 
> to repair a full cluster without doing any duplication of work. Doing the 
> same only within a data-center is obviously desirable.
> I think a reasonably simple solution would be modify the behavior of '-pr' 
> when it's limited to only one DC. If applied to nodeX in dcY, instead of 
> repairing only the "primary" range of nodeX for the whole ring, we'll repair 
> that range but also all ranges that are "primary" for a node not in dcY and 
> for which nodeX is the first node of dcY found in ring order. Basically we'll 
> ensure that running 'repair -local -pr' on every nodes of a given DC will 
> repair all ranges for the nodes of that DC without repairing the same range 
> twice.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to