[
https://issues.apache.org/jira/browse/CASSANDRA-16749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366775#comment-17366775
]
Zoltan Ersek commented on CASSANDRA-16749:
------------------------------------------
Seems to be working fine after testing:
{noformat}
Publishing:
org.apache.cassandra.schema.SchemaAnnouncementEvent={endpointIgnored=[localhost/127.0.0.1:7000],
statement={keyspace=test4, type=CREATE_KEYSPACE},
endpointDestinations=[]}{noformat}
Regarding toString():
Like Michael said, we will not know in the future if it's safe to change
toString or not, since it could potentially be used by some client(log parsing
or something) and could break it.
> DiagnosticEventService.publish logging logs events without an overridden
> toString causing less useful debug logs
> ----------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-16749
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16749
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Logging
> Reporter: David Capwell
> Assignee: Zoltan Ersek
> Priority: Low
> Fix For: 4.0.1, 4.1
>
> Attachments: 16749-trunk.txt
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The DiagnosticEventService logs each publish (if the event is enabled) using
> a logger, but the different events do not override the toString; this leaves
> the following logs
> {code}
> Publishing: org.apache.cassandra.gms.GossiperEvent@3cadeef2
> Publishing: org.apache.cassandra.gms.GossiperEvent@6159419d
> Publishing:
> org.apache.cassandra.service.PendingRangeCalculatorServiceEvent@18e52b1
> Publishing: org.apache.cassandra.locator.TokenMetadataEvent@43a76a1a
> etc.
> {code}
> To make these logs more meaningful, we might want to consider matching the
> persistent logic and convert the event to a map and then logging the map
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
