[
https://issues.apache.org/jira/browse/CASSANDRA-16759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368804#comment-17368804
]
Marcus Eriksson edited comment on CASSANDRA-16759 at 6/24/21, 3:25 PM:
-----------------------------------------------------------------------
by clearing out the memoized minVersion in {{start()}} we might call
{{upgradeFromVersionSupplier}} before we know anything about the cluster
pushed a new patch which makes sure we don't memoize anything before we
actually have {{endpointStateMap}} populated with something usable, tests
running (edit: still broken)
was (Author: krummas):
by clearing out the memoized minVersion in {{start()}} we might call
{{upgradeFromVersionSupplier}} before we know anything about the cluster
pushed a new patch which makes sure we don't memoize anything before we
actually have {{endpointStateMap}} populated with something usable, tests
running
> Avoid memoizing the wrong min cluster version during upgrades
> -------------------------------------------------------------
>
> Key: CASSANDRA-16759
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16759
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Coordination
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 4.0-rc2
>
>
> CASSANDRA-16525 avoids trying to calculate the cluster min version if
> gossiper is not enabled.
> This makes us memoize the wrong version for up to a minute causing us to send
> 4.0-messages to 3.0 nodes, for example in
> [ColumnFilter|https://github.com/apache/cassandra/blob/05beda90a9206db165a3997a736ecb06f8dc695e/src/java/org/apache/cassandra/db/filter/ColumnFilter.java#L210]
> This was discovered by python upgrade dtests,
> [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/993/workflows/2afef6f0-1356-41f6-93dc-5385ac19dca1/jobs/5977/tests#failed-test-0]
> after reverting CASSANDRA-15899 in CASSANDRA-16735
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
