[
https://issues.apache.org/jira/browse/CASSANDRA-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372199#comment-17372199
]
Brandon Williams edited comment on CASSANDRA-11671 at 6/30/21, 9:06 PM:
------------------------------------------------------------------------
||Branch||Circle||
|[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-11671-4.0]|[build|https://app.circleci.com/pipelines/github/driftx/cassandra?branch=CASSANDRA-11671-4.0]|
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-11671-trunk]|[build|https://app.circleci.com/pipelines/github/driftx/cassandra?branch=CASSANDRA-11671-trunk]
was (Author: brandon.williams):
||Branch||Circle||
|[3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-11671]|[build|https://app.circleci.com/pipelines/github/driftx/cassandra?branch=CASSANDRA-11671]|
|[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-11671-4.0]|[build|https://app.circleci.com/pipelines/github/driftx/cassandra?branch=CASSANDRA-11671-4.0]|
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-11671-trunk]|[build|https://app.circleci.com/pipelines/github/driftx/cassandra?branch=CASSANDRA-11671-trunk]
> Remove check on gossip status from DynamicEndpointSnitch::updateScores
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-11671
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11671
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Coordination
> Reporter: Sam Tunnicliffe
> Assignee: Artsiom Yudovin
> Priority: Low
> Labels: pull-request-available
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It seems that historically there were initialization ordering issues which
> affected DES and StorageService (CASSANDRA-1756) and so a condition was added
> to DES::updateScores() to ensure that SS had finished setup. In fact, the
> check was actually testing whether gossip was active or not. CASSANDRA-10134
> preserved this behaviour, but it seems likely that the check can be removed
> from DES completely now. If not, it can at least be switched to use
> SS::isInitialized() which post CASSANDRA-10134 actually reports what it's
> name suggests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
