Author: jbellis
Date: Thu Jun 23 15:54:05 2011
New Revision: 1138952
URL: http://svn.apache.org/viewvc?rev=1138952&view=rev
Log:
DTPE comment incorrectly claimed that its rejected execution handler preserved
task serialization
Modified:
cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/concurrent/DebuggableThreadPoolExecutor.java
Modified:
cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/concurrent/DebuggableThreadPoolExecutor.java
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/concurrent/DebuggableThreadPoolExecutor.java?rev=1138952&r1=1138951&r2=1138952&view=diff
==============================================================================
---
cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/concurrent/DebuggableThreadPoolExecutor.java
(original)
+++
cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/concurrent/DebuggableThreadPoolExecutor.java
Thu Jun 23 15:54:05 2011
@@ -57,9 +57,9 @@ public class DebuggableThreadPoolExecuto
super(corePoolSize, corePoolSize, keepAliveTime, unit, workQueue,
threadFactory);
allowCoreThreadTimeOut(true);
- // preserve task serialization. this is more complicated than it
needs to be,
- // since TPE rejects if queue.offer reports a full queue. we'll just
- // override this with a handler that retries until it gets in. ugly,
but effective.
+ // block task submissions until queue has room.
+ // this is fighting TPE's design a bit because TPE rejects if
queue.offer reports a full queue.
+ // we'll just override this with a handler that retries until it gets
in. ugly, but effective.
// (there is an extensive analysis of the options here at
//
http://today.java.net/pub/a/today/2008/10/23/creating-a-notifying-blocking-thread-pool-executor.html)
this.setRejectedExecutionHandler(new RejectedExecutionHandler()
