[
https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17381002#comment-17381002
]
Berenguer Blasi commented on CASSANDRA-16621:
---------------------------------------------
{quote}spinAssertEquals when possible, and reserve the direct call to
Awaitility for those cases in which more flexibility is required?{quote}
+1. I wouldn't replace all spinAssert calls just it's implementation to use
Awaitility. And you can call that one directly when needed
{quote}I wonder whether it would be too low{quote}
A thread.yield is probably less that that. But moving to 100ms would might even
make more sense to avoid spinning the CPU on yields. I wonder what Awaitility
does under the covers though..
> Replace spinAsserts code with Awaitility code
> ---------------------------------------------
>
> Key: CASSANDRA-16621
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16621
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Berenguer Blasi
> Assignee: Jogesh Anand
> Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 4.0.x
>
>
> Currently spinAsserts does a similar thing to Awaitility which is being used
> more and more. We have now 2 ways of doing the same thing so it would be good
> to consolidate
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
