[ https://issues.apache.org/jira/browse/CASSANDRA-16809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382785#comment-17382785 ]
Michael Semb Wever edited comment on CASSANDRA-16809 at 7/18/21, 9:14 AM: -------------------------------------------------------------------------- CI - trunk [!https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-cqlsh-dockerised/73/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-cqlsh-dockerised/73/] - 4.0 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-cqlsh-dockerised/72/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-cqlsh-dockerised/72/] - 3.11 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-cqlsh-dockerised/70/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-cqlsh-dockerised/70/] - 3.0 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-cqlsh-dockerised/71/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-cqlsh-dockerised/71/] Tests look good (parity to branches). was (Author: michaelsembwever): CI - 3.11 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-cqlsh-dockerised/70/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-cqlsh-dockerised/70/] - 3.0 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-cqlsh-dockerised/71/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-test-cqlsh-dockerised/71/] Tests look good (parity to branches). > Dockerise cqlshlib tests > ------------------------ > > Key: CASSANDRA-16809 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16809 > Project: Cassandra > Issue Type: Improvement > Components: CI, Test/dtest/python > Reporter: Michael Semb Wever > Assignee: Michael Semb Wever > Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x > > > The cqlshlib tests are the last remaining tests that don't run in docker. > Before 4.0 the cqlshlib builds are > [hardcoded|https://github.com/apache/cassandra/blob/cassandra-3.11/pylib/cassandra-cqlsh-tests.sh#L60] > to python2, but the test docker image [doesn't support > python2|https://github.com/apache/cassandra-builds/blob/trunk/docker/testing/ubuntu2004_j11.docker#L99-L117]. > (Maybe this is why cqlshlib tests don't exist in pre 4.0 circleci?) > Dockerising the cqlshlib tests, makes it a lot easier to keep jenkins' agents > clean of zombie processes. > Patches: > - cassandra-builds: https://github.com/apache/cassandra-builds/pull/50 > - 3.11: > https://github.com/apache/cassandra/compare/cassandra-3.11...thelastpickle:mck/dockerise-cqlsh-tests/3.11 > - 3.0: > https://github.com/apache/cassandra/compare/cassandra-3.0...thelastpickle:mck/dockerise-cqlsh-tests/3.0 > Patches are not required for 4.0 and trunk, as the {{--no-site-packages}} > flag to virtualenv has already been removed from them. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org