[ 
https://issues.apache.org/jira/browse/CASSANDRA-15737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387280#comment-17387280
 ] 

Benjamin Lerer commented on CASSANDRA-15737:
--------------------------------------------

[~jwest] are you planning to finish the patch?

I had a quick look at the patch and it seems that the 
{{getDynamicBadnessThreshold}} method is not returning anything. Was it 
intended?

> Add StorageServiceMBean#setDynamicBadnessThreshold to expose dynamic badness 
> threshold
> --------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15737
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15737
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Messaging/Internode
>            Reporter: Jordan West
>            Assignee: Jordan West
>            Priority: Normal
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> https://issues.apache.org/jira/browse/CASSANDRA-12179 made the 
> DynamicEndpointSnitch properties dynamic at runtime but didn’t expose a 
> method to modify badness threshold. This can be useful in operations that 
> also modify severity manually or if operators want to temporarily disable 
> dynamic snitch behavior. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to