[ 
https://issues.apache.org/jira/browse/CASSANDRA-16725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388238#comment-17388238
 ] 

Stefan Miklosovic commented on CASSANDRA-16725:
-----------------------------------------------

[https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/981/]

PR / branch is same

changes included:

1) composite data rewritten, they are no on "options" as discussed in PR, the 
whole class is simplified because of that a lot

2) added virtual table for audit log options

3) added AuditLogManagerMBean

4) Added more options into nodetool's enableauditlog (to be on par with 
fullquerylog)

I am not sure if I can move remaining "enable" methods from StorageService to 
new AuditLogManager. I know there is some policy about backward compatible 
interfaces and we should at most mark some methods as deprecated if new are 
introduced however here we are adding completely new MBean and I am not sure 
what to do in that case.

> Implement nodetool getauditlog command
> --------------------------------------
>
>                 Key: CASSANDRA-16725
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16725
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tool/auditlogging
>            Reporter: Stefan Miklosovic
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 4.1
>
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> There is getfullquerylog already, there is not any reason why getauditlog 
> should not be there too. A user can not retrieve runtime configuration of 
> Audit log, it might be only enabled and disabled via jmx but its state can 
> not be queried in runtime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to