[
https://issues.apache.org/jira/browse/CASSANDRA-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17397463#comment-17397463
]
Ekaterina Dimitrova edited comment on CASSANDRA-16835 at 8/11/21, 4:29 PM:
---------------------------------------------------------------------------
Thank you for the review.
{quote}The bug fixed was around completed/finished.isEmpty()?
{quote}
Yes, that is the one, I guess I had to put it in a separate commit for clarity.
Sorry.
I will propagate also to trunk and run full CI on all three branches for sanity
check.
was (Author: e.dimitrova):
Thank you for the review.
{quote}The bug fixed was around completed/finished.isEmpty()?
{quote}
Yes, that is the one, I guess I had to put it in a separate commit for clarity.
Sorry, I had to do that.
> Scrub still uses "row" to mean "partitions", and has broken code
> ----------------------------------------------------------------
>
> Key: CASSANDRA-16835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16835
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 3.11.x, 4.0.x, 4.x
>
>
> 2 issues in the scrub code:
> 1) It still uses "row" to mean "partition". And not only in the code, but
> also in user messages. As we've fairly systematically remove such instances
> elsewhere in 3.0+, having it in scrub is going to confuse users which will
> almost surely misinterpret the results. If scrub says that it dropped 2
> unreadable "rows" from your sstable, you might be ok with that when we're
> actually talking about CQL rows, but not if we talk of 2 full partitions.
> 2) There is a branch at the end of scrub that is supposed to handle the case
> where scrubbing a sstable generates no output at all (the sstable is
> completely hosed usually), mostly providing a more user friendly message. The
> code is broken (and has been for a long time, since CASSANDRA-7066 I believe)
> however such that this branch can simply never be taken (even when it
> should). While admittedly pretty minor, no reason to leave it that way.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
