[ 
https://issues.apache.org/jira/browse/CASSANDRA-16806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402819#comment-17402819
 ] 

Aleksei Zotov commented on CASSANDRA-16806:
-------------------------------------------

[~blerer]

I made some progress and I'd like to verify the direction I'm moving towards. 
My idea is to introduce {{AbstractWritableVirtualTable}} class that is 
responsible for handling modifications on a granular level. A developer will 
have to implement necessary methods that they want to support in their VT. Here 
it is: 
https://github.com/apache/cassandra/pull/1117/files#diff-850203d5ef3453529dd861d4d9ee487fd908ab4bd29177be5c70fcd0b58be3c4

I've also updated the tests, the approach seems to be working fine for every 
use case. However, I'd like to pay attention to 
{{ModificationStatement.validate}} and {{DELETE statements must restrict all 
PRIMARY KEY columns}}. In the meantime, could you please provide some initial 
feedback.

> Allow TRUNCATE to work on Virtual Tables if the implementation allows it
> ------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16806
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16806
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Feature/Virtual Tables
>            Reporter: Benjamin Lerer
>            Assignee: Aleksei Zotov
>            Priority: Normal
>             Fix For: 4.x
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> {{TRUNCATE}} statements are currently not supported by Virtual Tables. For 
> some Virtual Tables it makes sense to allow it.
> It can be done by adding a {{truncate}} method to the {{VirtualTable}} 
> interface and calling that method from {{TruncateStatement}}. The default 
> implementation of the method should be to fire an {{InvalidRequestException}} 
> saying that truncate is not supported on that specific table.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to