[
https://issues.apache.org/jira/browse/CASSANDRA-14309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405863#comment-17405863
]
Stefan Miklosovic commented on CASSANDRA-14309:
-----------------------------------------------
Yes that is also a possibility. My idea was to actually use that method but
without this fancy logic around. It would at least check for the expiration as
such without checking anything more. There might be "smart and dumb" version of
"shouldHint" and this previous, simplified version, would be used here.
If we get rid of calling "shouldHint" in "writeForAllReplicas", we would
actually change the behaviour a lot because the original shouldHint includes
checks for hinting to other dcs and so on. I would preserve that logic there. I
would just leave out "earliest hint check".
Maybe we meant same thing, not sure we are on the same page here.
> Make hint window persistent across restarts
> -------------------------------------------
>
> Key: CASSANDRA-14309
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14309
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Hints
> Reporter: Kurt Greaves
> Assignee: Stefan Miklosovic
> Priority: Low
> Fix For: 4.1
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The current hint system stores a window of hints as defined by
> {{max_hint_window_in_ms}}, however this window is not persistent across
> restarts.
> Examples (cluster with RF=3 and 3 nodes, A, B, and C):
> # A goes down
> # X ms of hints are stored for A on B and C
> # A is restarted
> # A goes down again without hints replaying from B and C
> # B and C will store up to another {{max_hint_window_in_ms}} of hints for A
>
> # A goes down
> # X ms of hints are stored for A on B and C
> # B is restarted
> # B will store up to another {{max_hint_window_in_ms}} of hints for A
>
> Note that in both these scenarios they can continue forever. If A or B keeps
> getting restarted hints will continue to pile up.
>
> Idea of this ticket is to stop this behaviour from happening and only ever
> store up to {{max_hint_window_in_ms}} of hints for a particular node.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
