[ 
https://issues.apache.org/jira/browse/CASSANDRA-16806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409137#comment-17409137
 ] 

Aleksei Zotov commented on CASSANDRA-16806:
-------------------------------------------

[~blerer]
{quote}It is ensured by the fact that virtual keyspaces are not user modifiable.
{quote}
Ok, good to know. Thanks for clarifying!
{quote}I do not think that there are any reason to restrict static columns. Why 
do you want to do it?
{quote}
I thought that static columns are not supposed to be supported based on your 
comment:
{quote}Firing an exception with the message {{DELETE statements must restrict 
all PRIMARY KEY columns with equality relations in order to use IF condition on 
non static columns}} *when it is not supported by the table* seems a bit weird 
to me.
{quote}
Are they? If yes, I'm wondering what are the use cases and expectations on the 
data source ({{DataSet}})? I feel it is a bit confusing and complicated to work 
with static columns assuming a regular data sources (like system properties, 
basic in-memory data structures, etc), however, it is theoretically possible. 
If there are no such usages at the moment, I'd probably restrict them (not in 
this ticket though). Please, let me know your thoughts.

PS:

Thanks for the feedback on the PR, that was valuable and helpful! I addressed 
all the comments, please, check sometime.

 

> Allow DELETE and TRUNCATE to work on Virtual Tables if the implementation 
> allows it
> -----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16806
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16806
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Feature/Virtual Tables
>            Reporter: Benjamin Lerer
>            Assignee: Aleksei Zotov
>            Priority: Normal
>             Fix For: 4.x
>
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> {{TRUNCATE}} statements are currently not supported by Virtual Tables. For 
> some Virtual Tables it makes sense to allow it.
> It can be done by adding a {{truncate}} method to the {{VirtualTable}} 
> interface and calling that method from {{TruncateStatement}}. The default 
> implementation of the method should be to fire an {{InvalidRequestException}} 
> saying that truncate is not supported on that specific table.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to