[ 
https://issues.apache.org/jira/browse/CASSANDRA-16971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418224#comment-17418224
 ] 

Ekaterina Dimitrova commented on CASSANDRA-16971:
-------------------------------------------------

Hey [~marcuse], may I ask you for a quick sanity check, please? I believe you 
added these tests some time ago. 

While I can't reproduce the mentioned issue neither locally, nor in the 
CircleCI multiplexer, I am fairly confident that we just need to add similar to 
CASSANDRA-15685 *Thread.sleep(1000)* after [this 
assert|https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/test/OptimiseStreamsRepairTest.java#L184]
 which does not guarantee that the job has completed. This should be enough to 
clear the flakiness and the Jenkins noise.

I think we can also add *Thread.sleep(1000)*  
[here|https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/test/OptimiseStreamsRepairTest.java#L91]
 to prevent also _testBasic()_ from being flaky. If you agree, I can take care 
to commit a quick patch for 4.0 and trunk where the tests exist.

 

 

> Fix org.apache.cassandra.distributed.test.OptimiseStreamsRepairTest.randomTest
> ------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16971
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16971
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/dtest/java
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.0
>
>
> org.apache.cassandra.distributed.test.OptimiseStreamsRepairTest.randomTest is 
> [failing|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1120/testReport/junit/org.apache.cassandra.distributed.test/OptimiseStreamsRepairTest/randomTest/]
>  on 4.0  
> h3.  
> {code:java}
> Error Message
> nodetool command [repair, distributed_test_keyspace, -vd] was not successful 
> stdout: [2021-09-15 16:45:34,539] Starting repair command #2 
> (58d1e2a0-1644-11ec-8c42-ef15a225544a), repairing keyspace 
> distributed_test_keyspace with repair options (parallelism: parallel, primary 
> range: false, incremental: true, job threads: 1, ColumnFamilies: [], 
> dataCenters: [], hosts: [], previewKind: REPAIRED, # of ranges: 3, pull 
> repair: false, force repair: false, optimise streams: false, ignore 
> unreplicated keyspaces: false) [2021-09-15 16:45:34,552] Repair command #2 
> failed with error Repair session 58d2cd00-1644-11ec-8c42-ef15a225544a for 
> range [(-3074457345618258603,3074457345618258601], 
> (9223372036854775805,-3074457345618258603], 
> (3074457345618258601,9223372036854775805]] failed with error An incremental 
> repair with session id 560ecb00-1644-11ec-8c42-ef15a225544a finished during 
> this preview repair runtime [2021-09-15 16:45:34,552] Repair command #2 
> finished with error
> {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to