[
https://issues.apache.org/jira/browse/CASSANDRA-16882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418871#comment-17418871
]
Ekaterina Dimitrova edited comment on CASSANDRA-16882 at 9/22/21, 11:37 PM:
----------------------------------------------------------------------------
Sorry for the delay, I had the impression you were still fixing something. Back
to this.
{quote}The workflow with an optional pre-commit job running most of the tests
would look like
[this|https://app.circleci.com/pipelines/github/adelapena/cassandra/843/workflows/da24c91a-0b6a-4370-a516-823cc4ad574d],
and like
[this|https://app.circleci.com/pipelines/github/adelapena/cassandra/843/workflows/f21093c4-1d9a-41b0-aaea-51c1b5c3c187]
for Java 11.
{quote}
I have two comments on this one:
* It is not related really to what you do, that is the way it was setup from
before but I was wondering - why do we have separate jobs for vnodes and no
vnodes for the cqlsh tests, but one job for the Python DTests that triggers
both versions?
* Unfortunately the list of jobs became so long that going over the button for
pre-commit jobs I can't follow anymore which jobs the arrows reach. Not sure we
can do anything more about that unfortunately.
Also, I guess all the failures are due to the lower resources.
About the second suggestion - I think you miss buttons for the cqlsh tests if I
look at the right build as the link points to two builds but the other build
miss the pre-commit button. This version looks cleaner but not sure when we add
the missing buttons that this will not change.
was (Author: e.dimitrova):
Sorry for the delay, I had the impression you were still fixing something. Back
to this.
{quote}The workflow with an optional pre-commit job running most of the tests
would look like
[this|https://app.circleci.com/pipelines/github/adelapena/cassandra/843/workflows/da24c91a-0b6a-4370-a516-823cc4ad574d],
and like
[this|https://app.circleci.com/pipelines/github/adelapena/cassandra/843/workflows/f21093c4-1d9a-41b0-aaea-51c1b5c3c187]
for Java 11.
{quote}
I have two comments on this one:
* It is not related really to what you do, that is the way it was setup from
before but I was wondering - why do we have separate jobs for vnodes and no
vnodes for the cqlsh tests, but one job for the tests that triggers both
versions?
* Unfortunately the workflow became so long that going over the button for
pre-commit jobs I can't follow anymore which jobs it reaches. Not sure we can
do anything more about that unfortunately.
Also, I guess all the failures are due to the lower resources.
About the second suggestion - I think you miss buttons for the cqlsh tests if I
look at the right build as the link points to two builds but the other one miss
the pre-commit button. This one looks cleaner but not sure when we add the
missing buttons that this will not change.
> Save CircleCI resources with optional test jobs
> -----------------------------------------------
>
> Key: CASSANDRA-16882
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16882
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
>
> This ticket implements the addition of approval steps in the CircleCI
> workflows as it was proposed in [this
> email|https://lists.apache.org/thread.html/r57bab800d037c087af01b3779fd266d83b538cdd29c120f74a5dbe63%40%3Cdev.cassandra.apache.org%3E]
> sent to the dev list:
> The current CircleCI configuration automatically runs the unit tests, JVM
> dtests and cqhshlib tests. This is done by default for every commit or, with
> some configuration, for every push.
> Along the lifecycle of a ticket it is quite frequent to have multiple commits
> and pushes, all running these test jobs. I'd say that frequently it is not
> necessary to run the tests for some of those intermediate commits and pushes.
> For example, one can show proofs of concept, or have multiple rounds of
> review before actually running the tests. Running the tests for every change
> can produce an unnecessary expense of CircleCI resources.
> I think we could make running those tests optional, as well as clearly
> specifying in the documentation what are the tests runs that are mandatory
> before actually committing. We could do this in different ways:
> # Make the entire CircleCI workflow optional, so the build job requires
> manual approval. Once the build is approved the mandatory test jobs would
> be run without any further approval, exactly as it's currently done.
> # Make all the test jobs optional, so every test job requires manual
> approval, and the documentation specifies which tests are mandatory in the
> final steps of a ticket.
> # Make all the mandatory test jobs depend on a single optional job, so we
> have a single button to optionally run all the mandatory tests.
> I think any of these changes, or a combination of them, would significantly
> reduce the usage of resources without making things less tested. The only
> downside I can think of is that we would need some additional clicks on the
> CircleCI GUI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
